From: Ray Strode <rstrode@redhat.com>
Date: Thu, 27 Jun 2019 18:27:34 +0000 (-0400)
Subject: animation: fix unintentional loop while polkit dialog is active
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~845^2^2~120
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=cb0a5de83bf94d73dc087b8ab879a63116f90f74;p=gnome-shell.git

animation: fix unintentional loop while polkit dialog is active

The polkit password dialog has a spinner that gets displayed
while the users password is being verified.

Unfortunately, the spinner stop method unintentionally calls
back into itself after the stop fade out animation is complete.
The stop method is called at startup, so the looping begins as
soon as the dialog is visible and continues until the dialog is
dismissed.

This commit fixes the loop by having the stop method cease
calling itself, and instead having it call the stop method on the
superclass.
---

diff --git a/js/ui/animation.js b/js/ui/animation.js
index c21b22565..58d7f4018 100644
--- a/js/ui/animation.js
+++ b/js/ui/animation.js
@@ -162,7 +162,7 @@ var Spinner = class extends AnimatedIcon {
                 time: SPINNER_ANIMATION_TIME,
                 transition: 'linear',
                 onComplete: () => {
-                    this.stop(false);
+                    super.stop();
                 }
             });
         } else {